29.MyIsern-1.3-review

Reviewed Team: myisern-1-green
Source Code: Here

Installation Review:
-There are no problem to run "ant -f verify.build.xml".
-WAR file can be generate.
-Be able to import project to eclipse.
-No error appear on eclipse.

Tool Execution:
Junit - OKey! Successful run all the test.
-Enable to see a status, when it run.

Checkstyle - OKey!

Emma - Okey!
emma.echo: [xslt] Processing C:\svn-google\myisern-1-green\build\emma\coverage.xml toC:\svn-google\myisern-1-green\build\emma\coverage.brief.txt
[xslt] Loading stylesheet C:\svn-google\myisern-1-green\lib\emma\hackystat.emma.xsl
[concat] Emma Coverage summary
[concat] class: 68% (17/25)
[concat] method: 57% (123/217)
[concat] block: 81% (5713/7044)
[concat] line: 80% (1315.7/1645)

Verify - Okey! Successful run all the test.
BUILD SUCCESSFUL

Code Format and Conventions Review:
File Line# violation Comment
No Violation Found!

The emma coverage is look not enough, I think you need to write a little bit more code on test case that bring up the emma coverage.

Black Box Perspective:
For LOGIN Page:
Enter username and password to test is it point to right page, or insert either one wrong input to test the page will display right error message.

For ADD Page:
Is the data will extract to right xml file and return message to user.
Do the page show all the field for each attributes.
Is the page had error handing.

For EDIT Page:
Is the show all the data of that attributes?
Is the page will point to right page when user click on submit button.
Is the page had error handing?

White Box Perspective:
White box testing include two parts, one is testing the system file which is myisern. Emma coverage will show the result of which parts the system do not cover. the other part is testing over the web, this test is only testing the web connection between the system and web server, also you need to write some code to cover all the web action.
For this case, your emma coverage no bad, but still need some to cover each requirement.

Break da buggah:
In this case, the first page is not a login page.
If I enter nothing in ADD page it will point it to web server error page, which is not successful to add data, and edit page too.

User Interface review:
Your system successful run on tomcat web server, and can be display each page.
Your had pretty nice user interface, clearly display the information on each page.

Summary and Lessons Learned:
What I learn on this assignment is transfer everythings into web interface, and it is very challenge on create user interface by using JSP which is totally new language, and I need to learn how to they implement to current system.