22.MyISERN-1.1.Review

Reviewed Author: Michal Zielinski
Source Code: Here

Installation Review:
-There are no problem to run "ANT".
-JAR file can be generate.
-Be able to import project to eclipse.
-No error appear on eclipse.

Tool Execution:
Junit - OKey! Successful run all the test.
-Enable to see a print out table of information from XML file, when it run.

Checkstyle - OKey!
checkstyle.tool:
-Created dir: C:\svn-google\myisern\build\checkstyle
-Running Checkstyle 4.3 on 10 files

PMD - Okey!
pmd.tool:
-Created dir: C:\svn-google\myisern\build\pmd
-No problems found!

FindBugs - Okey!
findbugs.tool:
-Created dir: C:\svn-google\myisern\build\findbugs-Running FindBugs...
-Output saved to C:\svn-google\myisern\build\findbugs/findbugs.xml

Emma - Okey!
Emma Coverage summary
class: 100% (9/9)
method: 100% (41/41)
block: 92% (2798/3039)
line: 91% (459/507)
It seem pretty good for emme coverage, it cover all class and method but some line of code didn't cover, it still okey. If you want to improve your coverage that you need to worry about some code such as try & catch, loop and some import function. It may cause your coverage not reach to 100%.

Verify - Okey! Successful run all the test.
BUILD SUCCESSFUL

Code Format and Conventions Review:

File	Line#	violation	Comment
No Violation Found!

So far has no error appear up to this point, next going to test is command line argument.

Black Box Perspective:
It is not doing well this part, since user does not know what format of argument they should put in, so it is the best way to print out what command line with no argument input to system, then user will understand how to access the system. So, I am a user in this case and I going to use your system, but I suppose know nothing about this system, so I have no idea how to access this system to get information that what I want. Therefore, I cannot do test on this part.

White Box Perspective:
Since, I can read your code and understand what are you doing on your code, then I run the system and put arguments on it to test it work.
On the other hand, your emme report you have
class: 100% (9/9)
method: 100% (41/41)
block: 92% (2798/3039)
line: 91% (459/507)
that mean some of block is not covered, the major result is on validation of argument that you need to use alot of error check things, but these error check will make some code cannot be cover, because error check including a lot of if statement, so these statement will block some conidition never exist will cause so code never be execute, then coverage will never be 100%.

Break da buggah:
In this case, it cannot break the system, if you have well error checking, but I found some condition that will break the system. when I input command "-listOrganizations -collaborationLevelEquals " that I put MAX_VALUE on argument will cause the system break.

Summary and Lessons Learned:
I read through your code and I really like you applet table, you make a table as applet and pop up by execute the system. It is a little off track to use applet print out table, but it is good to reference for me that how to write applet in java.